| title: | Re PATCH 8 8 v2 usb musb Using runtime |
|
"Kalliguddi, Hema" <hemahk@xxxxxx writes:
static int musb_platform_resume(struct musb *musb)
{
u32 l;
+ struct device *dev = musb- controller;
+ struct musb_hdrc_platform_data *pdata = dev- platform_data;
+ struct platform_device *pdev = to_platform_device(dev);
if (!musb- clock)
return 0;
otg_set_suspend(musb- xceiv, 0);
-
- if (musb- set_clock)
- musb- set_clock(musb- clock, 1);
- else
- clk_enable(musb- clock);
-
- l = musb_readl(musb- mregs, OTG_SYSCONFIG);
- l &= ~ENABLEWAKEUP; /* disable wakeup */
- musb_writel(musb- mregs, OTG_SYSCONFIG, l);
-
+ pm_runtime_enable(dev);
+ pm_runtime_get_sync(dev);
+ pdata- enable_wakeup(pdev);
I think you mean - disable_wakeup() here, right?
No I meant enable_wakeup only here. When smart idle/standby is enabled,
wakeup bit has to be set to generate the s-wakeup when the devie is in idle
and system is in ret.
OK, Im confused.
The code being removed just above disables wakeups and the new code
enables wakeups.
Also, you dont ever call - disable_wakeup() elsewhere in the patch.
You call pdata- enable_wakeup() both in suspend and resume.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|
