| title: | Re REVIEW PATCH 11 14 OMAP34XXCAM Add dri |
|
On Thu, Feb 12, 2009 at 1:22 PM, DongSoo Kim <dongsoo.kim@xxxxxxxxx wrote:
Thank you for your comment.
BTW, what should I do if I would rather use external ISP device than
OMAP3 internal ISP feature?
You said that you just have raw sensors by now, so you mean this patch
is not verified working with some ISP modules?
Hi DongSoo,
The driver is tested and working with sensors which have
inbuilt ISP modules.
Thanks,
Arun
Im testing your patch on my own omap3 target board with NEC ISP...but
unfortunately not working yet ;(
I should try more harder. more research is needed :)
Cheers,
On Thu, Feb 12, 2009 at 4:09 PM, Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
DongSoo Kim wrote:
Hello.
Hi, and thanks for the comments!
+static int omap34xxcam_open(struct inode *inode, struct file *file)
+{
<snip
+ if (atomic_inc_return(&vdev- users) == 1) {
+ isp_get();
+ if (omap34xxcam_slave_power_set(vdev, V4L2_POWER_ON,
+
OMAP34XXCAM_SLAVE_POWER_ALL))
+ goto out_slave_power_set_standby;
+ omap34xxcam_slave_power_set(
+ vdev, V4L2_POWER_STANDBY,
+ OMAP34XXCAM_SLAVE_POWER_SENSOR);
+ omap34xxcam_slave_power_suggest(
+ vdev, V4L2_POWER_STANDBY,
+ OMAP34XXCAM_SLAVE_POWER_LENS);
+ }
Im wondering whether this V4L2_POWER_STANDBY operation for sensor
device is really necessary.
Because if that makes sensor device in standby mode, we do S_FMT and
bunch of V4L2 APIs while the camera module is in standby mode.
In most cases of "sensor + ISP" SOC camera modules, I2C command is not
working while the camera module is in standby mode.
I guess that applies to most sensors.
Following the camera interface source code, sensor goes down to
standby mode until VIDIOC_STREAMON is called.
If this power up timing depends on sensor device, then I think we need
a conditional power on sequence.
Youre right, theres something wrong with the slave power handling. :)
We were thinking that the sensor (or any slave) power management (current
on, off and standby) could be replaced by four commands: open, close,
streamon and streamoff. The slave could decide by itself what its real power
state is. IMO direct power management doesnt belong to the camera driver
which doesnt drive any hardware anyway.
As you defined slave devices as SENSOR, LENS, FLASH, then how about
making a new slave category like "ISP" for "sensor+ISP" SOC modules?
I currently have just raw sensors. Itd be nice to keep the interface for
smart sensors the same, though. You still need for a receiver for the image
data, sometimes called the camera controller. That would be the same than
the ISP but without fancy features.
Cheers,
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx
--
========================================================
Dong Soo, Kim
Engineer
Mobile S/W Platform Lab. S/W centre
Telecommunication R&D Centre
Samsung Electronics CO., LTD.
e-mail : dongsoo.kim@xxxxxxxxx
dongsoo45.kim@xxxxxxxxxxx
========================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|
